Landscape on Code Review

The Landscape guys mentioned three things that I've missed in Your Code Sucks and I Hate You.

• The important thing about code reviews is that they are a conversation. Emphasise this in your team's code review culture.
• Don't speak to the person, speak to the code. "Why does the code do this?" rather than "Why did you do this?".
• Remember that the person who wrote the patch is an expert in that patch.

From the Hands

Just starting at UDS after a week at Canonical's Allhands event. Allhands was great, but one of the highlights for me was the Landscape team's presentation on their development process:

We optimize for fun. If something works really well in theory but it makes things less fun, then we don't do it.