- The important thing about code reviews is that they are a conversation. Emphasise this in your team's code review culture.
- Don't speak to the person, speak to the code. "Why does the code do this?" rather than "Why did you do this?".
- Remember that the person who wrote the patch is an expert in that patch.
Hacking, Software Collaboration, Testing and Diverse Other Topics of General Interest to the Practicing Programmer
Monday, May 25, 2009
Landscape on Code Review
The Landscape guys mentioned three things that I've missed in Your Code Sucks and I Hate You.
Subscribe to:
Post Comments (Atom)
Blog Archive
-
►
2010
(68)
-
►
November
(14)
- testtools manuals
- Tests that print stuff
- Boiling kettles, unit tests and data
- Big or small?
- "Don't Make Me Think", thoughts for Launchpad
- Reviewing specs, rock on!
- Having an extra feature never hurts, rebutted
- And then what?
- Make it really easy to fix bugs on Ubuntu
- What else have you got?
- Ubuntu in a VM on OS X?
- Still going
- What to do, what to do
- Launchpad and UDS-N
-
►
November
(14)

0 comments:
Post a Comment